Skip to content

[Backport] Fix #10747: Raise type error on unreducible match type #13519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Sep 16, 2021
Merged

[Backport] Fix #10747: Raise type error on unreducible match type #13519

merged 10 commits into from
Sep 16, 2021

Conversation

anatoliykmetyuk
Copy link
Contributor

No description provided.

@OlivierBlanvillain @anatoliykmetyuk
Fix scala#10747: Raise type error on unreducible MT
2640347
@OlivierBlanvillain @anatoliykmetyuk
Don't simplify MT right-hand sides
f99a60b
@OlivierBlanvillain @anatoliykmetyuk
Update neg test error annotations
af62bfe
@OlivierBlanvillain @anatoliykmetyuk
Don't normalize in VarianceChecker
68e29d7
@OlivierBlanvillain @anatoliykmetyuk
Add test case
9578122
@OlivierBlanvillain @anatoliykmetyuk
Fix scala#12974: Add test case
55d1378
@OlivierBlanvillain @anatoliykmetyuk
Fix 10747-shapeless-min.scala
e6b8604 
Don't consider types to be fullyInstanciated when containing a TypeParamRef.
@OlivierBlanvillain @anatoliykmetyuk
Update invariantDisjoint check
fbfba7c 
The previous check was too conservative, is we have a proof that A and B are
disjoint, then A and B in Inv[A] and Inv[B] are clearly different types, and
Inv[A] and Inv[B] are disjoint. Also the isSameType() && fullyInstantiated
check is quite primitive, it can still be useful in some cases.
@OlivierBlanvillain @anatoliykmetyuk
Update check files
b56eeaa
@anatoliykmetyuk
Copy link
Contributor Author

Scaladoc test failed:

2021-09-14T06:29:56.1461820Z [error] Test dotty.tools.scaladoc.sourcelinks.RemoteLinksTest.runTest failed: Page https://github.com/lampepfl/dotty/blob/f3305d43544c7b2507661a9c0b3748ed2962ea05/library/src/scala/CanThrow.scala does not exists, took 0.2 sec
2021-09-14T06:29:56.2665019Z [error] Failed: Total 4, Failed 1, Errors 0, Passed 3
2021-09-14T06:29:56.2674455Z [error] Failed tests:
2021-09-14T06:29:56.2678095Z [error] 	dotty.tools.scaladoc.sourcelinks.RemoteLinksTest
2021-09-14T06:29:56.3567112Z [error] (scaladoc / SourceLinksIntegrationTest / test) sbt.TestsFailedException: Tests unsuccessful
2021-09-14T06:29:56.3774220Z [error] Total time: 412 s (06:52), completed Sep 14, 2021 6:29:56 AM

@pikinier20 @BarkingBad @KacperFKorban does anyone know why?

@pikinier20
Copy link
Contributor

This error happens because CanThrow is in src-bootstrapped. Some time ago I did a workaround for one of PRs but apparently it didn't get merged to release branch.

You can take a look at it here: dotty-staging#19

@anatoliykmetyuk
Copy link
Contributor Author

Is it merged in master? Anywhere I can cherry-pick it from?

@pikinier20
Copy link
Contributor

I see that my commit wasn't merged to any branch but the problem is resolved by temporary disabling source links test (it's disabled on master). #13448

@dwijnand dwijnand mentioned this pull request Sep 14, 2021
Merged
@dwijnand dwijnand added this to the 3.1.0 milestone Sep 14, 2021
@Kordyjan Kordyjan merged commit fe8debc into scala:release-3.1.0 Sep 16, 2021
@Kordyjan Kordyjan deleted the backport-12768 branch September 16, 2021 06:43
@Kordyjan Kordyjan mentioned this pull request Sep 16, 2021
Closed
12 tasks
@bishabosha bishabosha mentioned this pull request Oct 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kordyjan Kordyjan Kordyjan approved these changes

@OlivierBlanvillain OlivierBlanvillain Awaiting requested review from OlivierBlanvillain

Assignees

@OlivierBlanvillain OlivierBlanvillain

Labels
None yet
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.
6 participants
@anatoliykmetyuk @pikinier20 @Kordyjan @dwijnand @OlivierBlanvillain @BarkingBad